Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): don't force set build.target when renderLegacyChunks=false (fixes #10201) #10220

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

sapphi-red
Copy link
Member

Description

#10072 force set build.target, but it's not necessary when renderLegacyChunks=false.
For example, when using plugin-legacy for only generating polyfills (#10201 (comment)).

fixes #10201

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red changed the title fix(legacy): don't force set build.target when renderLegacyChunks=false fixes #10201 fix(legacy): don't force set build.target when renderLegacyChunks=false (fixes #10201) Sep 23, 2022
@patak-dev patak-dev merged commit 7f548e8 into vitejs:main Sep 23, 2022
@sapphi-red sapphi-red deleted the fix-legacy-dont-force-set-target branch September 23, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly setting targets does not prevent @vitejs/plugin-legacy from overriding build.target
3 participants